Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Update dependencies per npm audit #2547

Merged
merged 4 commits into from
Jan 5, 2021
Merged

Chore: Update dependencies per npm audit #2547

merged 4 commits into from
Jan 5, 2021

Conversation

codebykat
Copy link
Member

Fix

Update dependencies as necessary to deal with npm audit warnings, which were getting excessive

Dependencies touched include: lodash, spectron, a number of auto-fixes to lower-level dependencies.

Test

  1. Build and smoke test the app
  2. Make sure npm test works

Release

Updated dependencies

@codebykat codebykat requested a review from a team January 5, 2021 09:18
@codebykat codebykat self-assigned this Jan 5, 2021
@codebykat codebykat added this to the 2.5.0 milestone Jan 5, 2021
nsakaimbo
nsakaimbo approved these changes Jan 5, 2021
View reviewed changes
Copy link

@nsakaimbo nsakaimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I gave the built app a smoke test on Windows and things seem to work as expected. 👍 (I noticed some unintuitive behavior with checklist items being entered individually, but that is unlikely related to this PR.)

@nsakaimbo
Copy link

Update: I think you'll want to update the README for the repo, which calls out the specific version of spectron being used.

@codebykat
Copy link
Member Author

README updated, checklist fix is up in #2548 (not introduced by this PR).

@codebykat codebykat merged commit 10bc2f3 into develop Jan 5, 2021
@codebykat codebykat deleted the update/deps branch January 5, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsakaimbo nsakaimbo nsakaimbo approved these changes

Assignees

@codebykat codebykat

Labels
None yet
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@codebykat @nsakaimbo