Refactor: Move tag suggestions into Redux #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmsnell
force-pushed
the
refactor/tag-suggestions-in-redux
branch
from
1fb6531 to
90a0ddc
Compare
Since we introduced tag suggestions in #1648 we have been recalculating the list of tag suggestions on every render, at least twice (once to get the count of tag suggestions in note-list and once in tag-suggestions). In order to prevent needless re-rendering we implemented custom memoization in the tag-suggestions component. In this patch we're moving the tag suggestions logic into our search module where the tag suggestions can update with the rest of the search results. By doing this we'll leave one place to update them, couple them with the filtered notes, and be able to remove our custom memoizatoin without losing the benefits it brought us.
dmsnell
force-pushed
the
refactor/tag-suggestions-in-redux
branch
from
90a0ddc to
d178f15
Compare
codebykat
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we introduced tag suggestions in #1648 we have been recalculating
the list of tag suggestions on every render, at least twice (once to get
the count of tag suggestions in
note-listand once intag-suggestions).In order to prevent needless re-rendering we implemented custom memoization
in the
tag-suggestionscomponent.In this patch we're moving the tag suggestions logic into our search module
where the tag suggestions can update with the rest of the search results.
By doing this we'll leave one place to update them, couple them with the
filtered notes, and be able to remove our custom memoizatoin without losing
the benefits it brought us.