Crash on missing platform support #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Simplenote app, for better or worse, currently depends on a few storage technologies that may be disabled through browser settings, extensions, and manual configuration. When these dependencies are missing we cannot function normally and right now the app crashes or breaks in misleading ways. In this patch we perform an up-front check when the app boots to verify that we have some basic dependencies met. This is not an exhaustive validation but it should catch the most common cases and give customers an idea of why things may be broken.
dmsnell
commented
Nov 12, 2019
| <BootWarning> | ||
| <p> | ||
| Simplenote depends on a few web technologies to operate. Please make | ||
| sure that you have all of the following enabled in your browser. |
There was a problem hiding this comment.
@SylvesterWilmott would you be willing to provide some copy-review on this?
This message is the only thing that would appear to a customer if they try to load Simplenote without having the necessary support enabled in the browser.
There was a problem hiding this comment.
The copy looks good to me! Thanks @dmsnell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Simplenote app, for better or worse, currently depends on a few
storage technologies that may be disabled through browser settings,
extensions, and manual configuration.
When these dependencies are missing we cannot function normally and
right now the app crashes or breaks in misleading ways.
In this patch we perform an up-front check when the app boots to verify
that we have some basic dependencies met. This is not an exhaustive
validation but it should catch the most common cases and give customers
an idea of why things may be broken.