Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the menu icon #1694

Merged
merged 4 commits into from
Nov 14, 2019
Merged

Updates the menu icon #1694

merged 4 commits into from
Nov 14, 2019

Conversation

belcherj
Copy link
Contributor

@belcherj belcherj commented Nov 5, 2019

Fix

We have a new icon set. This updates the menu icon to the new one.

This PR shows how the icons will be updated. In an additional PR, the remaining icons will be updated. Would you make any changes to the icon components as we switch out the svg?

Test

  1. Open app
  2. Does the menu icon in the top left render correctly?
  3. Does it render correctly in the Dark theme?
  4. Does it render correctly in Electron app

Review

Only one developer and one designer are required to review these changes, but anyone can perform the review.

Release

RELEASE-NOTES.txt was updated with:

  • Updated menu icon to use the new icon set #1694

@belcherj belcherj added this to the 1.12 milestone Nov 5, 2019
@belcherj belcherj requested a review from a team November 5, 2019 15:29
@belcherj belcherj self-assigned this Nov 5, 2019
@belcherj belcherj merged commit eb883cc into develop Nov 14, 2019
@belcherj belcherj deleted the update/menu-icon branch November 14, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants