Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow some HTML in lesson video embed code #2992

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

bhavik-dreamz
Copy link

@bhavik-dreamz bhavik-dreamz commented Mar 27, 2020

lesson allow video tags allowing any tags here that wp_kses_post allows

Fixes #
i am getting issue with video allow html tags
I have replaced allowed_html tag with default kses_allowed_html with the same structure

Changes proposed in this Pull Request:

Testing instructions:

*please check in allowed_html in file class-sensi-lesson.php and class-sensi fronted.php both are different so i make same like class-sensi-lesson.php in class-sensi fronted.php

Screenshot / Video

Proposed changelog entry for your changes:

lesson allow video tags allowing any tags here that wp_kses_post allows
@donnapep
Copy link
Collaborator

donnapep commented May 12, 2020

@dydrema This looks good, but I'm not going to merge just yet as this PR needs to ship with #2950, and that pull request needs some changes. Actually, I think it would be a good idea to close #2950 and make those changes in this PR instead.

@donnapep donnapep added [Status] Needs Author Reply Requires response from the author and removed [Status] Needs Author Reply Requires response from the author labels May 12, 2020
@donnapep donnapep changed the title lesson video tags allow post too Allow some HTML in lesson video embed code May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants