Gradle Wrapper Validation

[oguzkocer]

Description

In Automattic/a8c-ci-toolkit-buildkite-plugin#34 we introduced our own script to validate the Gradle Wrapper which uses the official documentation for its implementation. This PR uses that script to add a prerequisite step to validate the Gradle Wrapper in both pipelines.

The main reason we decided to add our own script as opposed to using the official Github Action was to be able to validate the Gradle Wrapper before running any of the Buildkite steps. As discussed in that PR, there are some edge cases our script doesn't cover. Furthermore, because it's a custom implementation, there is always a chance that it gets outdated. Therefore, we are adding the official Github Action alongside our own script.

After this PR is merged, I suggest we add the Github Action as a required step for trunk branch. The Buildkite step is already a prerequisite for the rest of the steps, so I don't think we need to add it as a required check, but having the Github Action as a required check should give us some extra peace of mind. Github only takes ~20s to validate the wrapper, so it shouldn't block developers unless there is an issue with it.

Testing Instructions

Verify that the Gradle Wrapper Validation is added as a prerequisite step to the Buildkite pipeline.

Checklist

• If this is a user-facing change, I have added an entry in CHANGELOG.md
• I have considered whether it makes sense to add tests for my changes
• All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
• Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

• with different themes
• with a landscape orientation
• with the device set to have a large display and font size
• for accessibility with TalkBack

[CLAassistant]

All committers have signed the CLA.

[ParaskP7]

👋 @oguzkocer !

Great work on the adding the Gradle Wrapper Validation checks in Pocket Casts Android! 🥇 ❤️ 🚀

I've reviewed and tested the PR as per the description and although everything LGTM I can't access neither the Actions tab, nor the Buildkite page, thus I am just commenting for now, without approving this change:

• Configuration Changes ✅
• Buildkite ⚠️
• GitHub Actions ⚠️

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

This might be related to the CLAssistant, but I am not sure... 🤔 Cc @leandroalonso

After this PR is merged, I suggest we add the Github Action as a required step for trunk branch.

I totally agree! 💯

[oguzkocer]

@Automattic/pocket-casts-android Can I sign the CLA agreement without having to connect my Github account? We also need someone from the team to review & merge this. Thanks!