Fix class properties should have defaults as standard js classes would have #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chearon
requested changes
Aug 11, 2024
mcfedr
force-pushed
the
props
branch
2 times, most recently
from
a4898dc
to
1e058c9
Compare
…d have Changed PNG consts to static properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2390
jsdom tries to replace some functions
in a normal js canvas, all the props are like standard js classes
this change adds the
napi_property_attributesfor thisalso some
InstanceValueare replaced withStaticValueas this is how they should have beenThis has changed in the 3.x RC with the move to napi