Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to node-addon-api (and N-API) and remove NAN, libuv, and v8 #2235

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Port to node-addon-api (and N-API) and remove NAN, libuv, and v8 #2235

merged 3 commits into from
Sep 19, 2023

Commits on Sep 19, 2023

  1. port to node-addon-api (remove NAN, v8, libuv)

    @chearon
    chearon committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    c32c39b View commit details
    Browse the repository at this point in the history

  2. optimize checkArgs 

    this makes the lineTo benchmark (lineTo executes a very small
number of operations, so it mostly measures the js<->C++ barrier)
run about 50% faster
    @chearon
    chearon committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    cc840a8 View commit details
    Browse the repository at this point in the history

  3. optimize fillStyle to be 10% faster 

    this is possibly a hot path, and avoiding the C++ string helps a
little bit
    @chearon
    chearon committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    afbec56 View commit details
    Browse the repository at this point in the history