Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix not compiling on certain windows versions #2216

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Conversation

chearon
Copy link
Collaborator

@chearon chearon commented Mar 25, 2023

msbuild is throwing this in the prebuild workflow, and I give up trying to figure out why it's different than the main workflow.

Error: D:\a\node-canvas\node-canvas\src\register_font.cc(261,18): error C2664: 'HANDLE CreateFileW(LPCWSTR,DWORD,DWORD,LPSECURITY_ATTRIBUTES,DWORD,DWORD,HANDLE)': cannot convert argument 6 from 'nullptr' to 'DWORD' [D:\a\node-canvas\node-canvas\build\canvas.vcxproj]

The error makes sense, this arg should not be NULL.

@zbjornson zbjornson merged commit 9910243 into master Mar 27, 2023
@zbjornson zbjornson deleted the ch/null-cast-windows branch March 27, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants