Fix BMP issues #1497
Merged
Fix BMP issues #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG.md
Outdated
| @@ -10,6 +10,7 @@ project adheres to [Semantic Versioning](http://semver.org/). | |||
| ### Changed | |||
| ### Added | |||
| ### Fixed | |||
| * Fix BMP issues. | |||
There was a problem hiding this comment.
I would describe what BMP issues there were. It would add more clarity.
zbjornson
reviewed
Dec 9, 2019
| blue = (val >> 8) << 3; | ||
| green = ((val >> 13) | (val << 3)) << 3; | ||
| red = (val >> 2) << 3; | ||
| alpha = 255; |
There was a problem hiding this comment.
Is this just RGB555? (I Googled the comment line and got no results :))
What you have is fine with me if you're short on time, but if it's indeed RGB555 I think you can simplify it by constructing val in the other byte order (untested):
val = U1UC();
val |= U1UC() << 8;
red = (val >> 10) << 3;
green = (val >> 5) << 3;
blue = val << 3;
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1492
Fixes #1495