fix: wizards - update type check conditional for custom_logo
#3442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredrethman
added
the
[Status] Needs Review
leogermani
reviewed
Sep 20, 2024
| @@ -520,7 +520,7 @@ public function api_update_theme_with_mods( $request ) { | |||
| continue; | |||
| } | |||
|
|
|||
| if ( null !== $value && in_array( $key, $this->media_theme_mods ) ) { | |||
| if ( '' !== $value && in_array( $key, $this->media_theme_mods ) ) { | |||
There was a problem hiding this comment.
if $value needs to be an array there, what about a more explicit check like ! empty( $value['id'] )
There was a problem hiding this comment.
Thanks for the feedback. I have updated with your recommendation 22c742a
leogermani
approved these changes
Sep 20, 2024
github-actions
bot
added
[Status] Approved
matticbot
pushed a commit
that referenced
this pull request
Sep 20, 2024
# [5.4.0-alpha.7](v5.4.0-alpha.6...v5.4.0-alpha.7) (2024-09-20) ### Bug Fixes * wizards - update type check conditional for `custom_logo` ([#3442](#3442)) ([125f756](125f756))
|
🎉 This PR is included in version 5.4.0-alpha.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Changes introduced in #3433 produced a bug relating to how
custom_logoandnewspack_footer_logotheme mods are saved.PHP Fatal error: Uncaught TypeError: Cannot access offset of type string on stringThis PR fixes this issue by correctly testing incoming values by the correct type.
How to test the changes in this Pull Request:
git checkout origin/fix/wizard-custom-logo-saveOther information: