-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove more callback
doc references & some small other changes
#15095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as "Double" is not something that exists on "mongoose"
also add some "emits" jsdoc on private functions
also combine "always true" paths for "aggregate"
…ntly uses typescript version and prevent warning in "npm lint"
hasezoey
added
docs
This issue is due to a mistake or omission in the mongoosejs.com documentation
developer-experience
This issue improves error messages, debugging, or reporting
labels
Dec 14, 2024
vkarpov15
approved these changes
Dec 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
developer-experience
This issue improves error messages, debugging, or reporting
docs
This issue is due to a mistake or omission in the mongoosejs.com documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR does a bunch of small maintenance things, mainly removing more
callback
documentation references, some other changes include:Double
from being assigned inindex.js
because it does not exist inmongoose
MongooseError
oncemongoose::model
anonymous
anymore)model::aggregate
Connection::on
andConnection::once
to the documentation@typescript-eslint/*
to fix warning innpm lint