Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more callback doc references & some small other changes #15095

Merged
merged 14 commits into from
Dec 15, 2024

Conversation

hasezoey
Copy link
Collaborator

Summary

This PR does a bunch of small maintenance things, mainly removing more callback documentation references, some other changes include:

  • remove Double from being assigned in index.js because it does not exist in mongoose
  • import & export MongooseError once
  • use consistent error constructors for mongoose::model
  • assign more function names (to not have them be anonymous anymore)
  • remove "always true" path in model::aggregate
  • expose Connection::on and Connection::once to the documentation
  • update @typescript-eslint/* to fix warning in npm lint

@hasezoey hasezoey added docs This issue is due to a mistake or omission in the mongoosejs.com documentation developer-experience This issue improves error messages, debugging, or reporting labels Dec 14, 2024
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 8.9.1 milestone Dec 15, 2024
@vkarpov15 vkarpov15 merged commit b7b257e into Automattic:master Dec 15, 2024
43 checks passed
@hasezoey hasezoey deleted the smallMaintenance branch December 15, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience This issue improves error messages, debugging, or reporting docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants