Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types(model): convert InsertManyResult to interface and remove unnecessary insertedIds override #14977

Merged
merged 1 commit into from
Oct 23, 2024
Merged

types(model): convert InsertManyResult to interface and remove unnecessary insertedIds override #14977

merged 1 commit into from
Oct 23, 2024

Conversation

vkarpov15
Copy link
Collaborator

Summary

Remove an unnecessary inconsistency between Mongoose types and MongoDB types

Examples

@vkarpov15 vkarpov15 added this to the 8.7.3 milestone Oct 21, 2024
@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Oct 22, 2024
@vkarpov15 vkarpov15 merged commit c342fc4 into master Oct 23, 2024
5 checks passed
@hasezoey hasezoey deleted the vkarpov15/insert-many-result-interface branch October 23, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees
No one assigned
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Milestone
8.7.3
Development

Successfully merging this pull request may close these issues.
2 participants
@vkarpov15 @hasezoey