Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: make __v a number, only set __v on top-level documents #14892

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

vkarpov15
Copy link
Collaborator

Re: #12959

Summary

Version key __v is only set on top-level documents at runtime, so TypeScript types should support that. We'll put this change in 8.7 in the interest of caution, because this may cause issues for people who use extends Document

Examples

@vkarpov15 vkarpov15 added this to the 8.7 milestone Sep 16, 2024
@vkarpov15 vkarpov15 changed the base branch from master to 8.7 September 16, 2024 21:10
test/types/document.test.ts Outdated Show resolved Hide resolved
test/types/document.test.ts Outdated Show resolved Hide resolved
vkarpov15 and others added 2 commits September 17, 2024 11:29
Co-authored-by: hasezoey <hasezoey@gmail.com>
Co-authored-by: hasezoey <hasezoey@gmail.com>
@vkarpov15 vkarpov15 merged commit d28e5a0 into 8.7 Sep 17, 2024
5 checks passed
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-12959 branch September 17, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants