Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): remove count() and findOneAndRemove() from query chaining #14692

Merged
merged 11 commits into from
Jul 1, 2024
Merged

fix(query): remove count() and findOneAndRemove() from query chaining #14692

merged 11 commits into from
Jul 1, 2024

Conversation

vkarpov15
Copy link
Collaborator

Fix #14689

Summary

A bit of an unfortunate case where mquery still supports count() and findOneAndRemove(), which means you can still access those functions in Mongoose 8 with query chaining. This PR removes that.

Examples

vkarpov15 and others added 11 commits June 24, 2024 10:15
@vkarpov15
fix(document): avoid passing validateModifiedOnly to subdocs so subdo…
758eca3 
…cs get fully validating if they're directly modified

Fix #14677
@vkarpov15
fix(projection): handle projections on arrays in Model.hydrate() pr…
36ea383 
…ojection option

Fix #14680
@vkarpov15
fix: handle casting primitive array with $elemMatch in bulkWrite()
091c85d 
Fix #14678
@tt-public
test: add type test for Connection.withSession
561a580
@tt-public
feat: fix return type of Connection.withSession
cc63f69
@vkarpov15
style: fix lint
8b05872
@vkarpov15
Merge pull request #14685 from Automattic/vkarpov15/gh-14677
c062b1f 
fix(document): avoid passing validateModifiedOnly to subdocs so subdocs get fully validating if they're directly modified
@vkarpov15
Merge pull request #14686 from Automattic/vkarpov15/gh-14680
516464a 
fix(projection): handle projections on arrays in `Model.hydrate()` projection option
@vkarpov15
Merge pull request #14687 from Automattic/vkarpov15/gh-14678
31111f2 
fix: handle casting primitive array with $elemMatch in bulkWrite()
@vkarpov15
Merge pull request #14690 from tt-public/feat/type-withsession
f89868b 
types(connection): fix return type of withSession()
@vkarpov15
fix(query): remove count() and findOneAndRemove() from query chai…
6136846 
…ning

Fix #14689
@vkarpov15 vkarpov15 added this to the 8.5 milestone Jun 25, 2024
AbdelrahmanHafez
AbdelrahmanHafez approved these changes Jun 30, 2024
View reviewed changes
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we need to modify the TS declarations for this as well?

@hasezoey
Copy link
Collaborator

hasezoey commented Jul 1, 2024

do we need to modify the TS declarations for this as well?

to my knowledge that has already been removed, the only mentions about count in the types are about $count and aggregate.count() (and estimatedDocumentCount)

@vkarpov15 vkarpov15 changed the base branch from master to 8.5 July 1, 2024 17:30
@vkarpov15 vkarpov15 merged commit 4ac878e into 8.5 Jul 1, 2024
46 checks passed
@hasezoey hasezoey deleted the vkarpov15/gh-14689 branch July 1, 2024 18:53
@akanchhaS akanchhaS mentioned this pull request Jul 30, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jul 30, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Jul 30, 2024
Open
@issam-seghir issam-seghir mentioned this pull request Jul 30, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Jul 30, 2024
Open
@k2xl k2xl mentioned this pull request Jul 30, 2024
Closed
@Habibullohnuriddin Habibullohnuriddin mentioned this pull request Jul 30, 2024
Open
@carltrepanier carltrepanier mentioned this pull request Jul 30, 2024
Merged
@ilovepixelart ilovepixelart mentioned this pull request Jul 30, 2024
Closed
@Erenkrs Erenkrs mentioned this pull request Sep 2, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Sep 2, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Sep 3, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Sep 3, 2024
Open
@issam-seghir issam-seghir mentioned this pull request Sep 3, 2024
Open
@aviraj1703 aviraj1703 mentioned this pull request Sep 3, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Sep 3, 2024
Open
@MihikaNigam MihikaNigam mentioned this pull request Sep 3, 2024
Open
This was referenced Sep 3, 2024
Open
Open
Open
@ibrahim-mohamed-zaghloul ibrahim-mohamed-zaghloul mentioned this pull request Sep 3, 2024
Open
@issam-seghir issam-seghir mentioned this pull request Sep 4, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Sep 4, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Sep 4, 2024
Open
@aviraj1703 aviraj1703 mentioned this pull request Sep 4, 2024
Open
@lholmquist lholmquist mentioned this pull request Sep 4, 2024
Closed
@NotZarifGithub NotZarifGithub mentioned this pull request Sep 4, 2024
Open
@Habibullohnuriddin Habibullohnuriddin mentioned this pull request Sep 4, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Sep 4, 2024
Open
@ibrahim-mohamed-zaghloul ibrahim-mohamed-zaghloul mentioned this pull request Sep 4, 2024
Open
This was referenced Sep 4, 2024
Open
Open
Open
@MihikaNigam MihikaNigam mentioned this pull request Sep 4, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Sep 4, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Sep 6, 2024
Open
@GoGPenguin GoGPenguin mentioned this pull request Sep 6, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Sep 6, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Sep 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez AbdelrahmanHafez approved these changes

@DevooKim DevooKim DevooKim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.5
Development

Successfully merging this pull request may close these issues.

Query.count / Query.findOneAndRemove are still alive
5 participants
@vkarpov15 @hasezoey @AbdelrahmanHafez @DevooKim @tt-public