-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: some cleanup re: #12890 #12919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly looks good to me, though there are some places that have not been changed yet, or were changed back to not properly close in case of test failure
Co-authored-by: hasezoey <hasezoey@gmail.com>
Co-authored-by: hasezoey <hasezoey@gmail.com>
…mongoose into vkarpov15/test-cleanup-12890
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Applied some suggestions from #12890. Mostly getting rid of unnecessary
connectionsToClose
- left it in one case where it makes sense. Also refactored out someModel.watch()
cases, and fixed a potential bug due to the MongoDB node driver continuing to poll after change stream is closed.Examples