7.0 driver cleanup #12839
Merged
7.0 driver cleanup #12839
+344
−397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… relying on driver to import Binary, ObjectId, Decimal128 Re: #12638
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -904,7 +893,7 @@ | |||
| continue; | |||
| } | |||
| if (typeof to[key] === 'undefined') { | |||
| to[key] = exports.clone(fromObj[key], { | |||
| to[key] = clone(fromObj[key], { | |||
Check warning
Code scanning / CodeQL
Prototype-polluting function
There was a problem hiding this comment.
i think this alert can be dismissed, ~5 lines above in the loop specialProperties are already skipped
|
if i understand correctly, this means a custom driver cannot provide types like ObjectId (etc) anymore and mongoose is now always using directly from |
hasezoey
approved these changes
Dec 28, 2022
| @@ -904,7 +893,7 @@ | |||
| continue; | |||
| } | |||
| if (typeof to[key] === 'undefined') { | |||
| to[key] = exports.clone(fromObj[key], { | |||
| to[key] = clone(fromObj[key], { | |||
There was a problem hiding this comment.
i think this alert can be dismissed, ~5 lines above in the loop specialProperties are already skipped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make drivers easier to implement, and minimize how hard-coded the MongoDB driver is in our code. Also remove the
require('../driver').get()calls that tend to confuse bundlers and cause hard-to-debug issues when implementing custom drivers. Drivers are now fully scoped to a single Mongoose instance, minus thedriver.jsfile which we still need to remove.Examples