Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛fix: improve inferred Schema Type #12007
🐛fix: improve inferred Schema Type #12007
Changes from 22 commits
bb2ef25
2e51745
73706cb
6277c4f
687d4db
e3679a8
79c9ce4
7d280a2
2f1d2d9
5ce27ac
d31aa08
4123249
d12af93
4037696
3def8c3
27614de
1abdb34
1c82c05
c64f97b
814a0db
dc5e52a
8aa7f53
ca6f97b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assumed not all of typeKey's types should be allowed to be remove the optional flag on that path.
So I set it to these 4. Because I think they're the only ones that should be able to provide defaults.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if you don't want the types to be limited, I'll revert the whole commit. @mohammad0-0ahmad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are just because I noticed they're defined in their respective SchemaDefinition types.