Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Mongoose 6 as compatible with MongoDB 4 #11320

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Mark Mongoose 6 as compatible with MongoDB 4 #11320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/compatibility.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ Below are the [semver](http://semver.org/) ranges representing which versions of
* MongoDB Server 3.2.x: mongoose `^4.3.0` or `5.x`
* MongoDB Server 3.4.x: mongoose `^4.7.3` or `5.x`
* MongoDB Server 3.6.x: mongoose `5.x`
* MongoDB Server 4.0.x: mongoose `^5.2.0`
* MongoDB Server 4.2.x: mongoose `^5.7.0`
* MongoDB Server 4.4.x: mongoose `^5.10.0`
* MongoDB Server 4.0.x: mongoose `^5.2.0` or `6.x`
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez Feb 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, we don't drop support for older MongoDB versions as we upgrade versions, so I assume it's safe to change this with:

Suggested change
* MongoDB Server 4.0.x: mongoose `^5.2.0` or `6.x`
* MongoDB Server 4.0.x: mongoose >= `^5.2.0`

Correct me if I'm wrong @vkarpov15

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that ^5.2.0 or 6.x is less brittle, because otherwise what happens with Mongoose 7?

* MongoDB Server 4.2.x: mongoose `^5.7.0` or `6.x`
* MongoDB Server 4.4.x: mongoose `^5.10.0` or `6.x`
* MongoDB Server 5.x: mongoose `^6.0.0`

Note that Mongoose 5.x dropped support for all versions of MongoDB before 3.0.0. If you need to use MongoDB 2.6 or older, use Mongoose 4.x.