Getters are called even though the getters flag is not set in the toObject function

[ajith92]

I am reporting a Bug, where getters are called even though getters flag is not set in the toObject function. when toObject is called with the getters flag as true, like below. getters function gets called twice.

document.toObject({getters: true})

This behavior has started to appear from version greater than 5.3.4.

My node.js, mongoose and MongoDB version.
node: v10.14.0
mongoose: 5.4.5
mongodb: v4.0.0

[vkarpov15]

The below script works as expected, getters don't run on the first toObject() and getters don't get double called.

const assert = require('assert');
const mongoose = require('mongoose');
mongoose.set('debug', true);

const GITHUB_ISSUE = `gh7442`;
const connectionString = `mongodb://localhost:27017/${ GITHUB_ISSUE }`;
const { Schema } = mongoose;

run().then(() => console.log('done')).catch(error => console.error(error.stack));

async function run() {
  await mongoose.connect(connectionString, { useNewUrlParser: true });
  await mongoose.connection.dropDatabase();

  const schema = new Schema({
    name: {
      type: String,
      get: function(v) {
        console.log('Getter called');
        return v;
      }
    }
  });
  const Model = mongoose.model('gh7442', schema);

  const doc = new Model({ name: 'test' });

  console.log('-------');

  doc.toObject();

  console.log('-------');

  doc.toObject({ getters: true });
}

Output:

$ node gh-7442.js 
-------
-------
Getter called
done
^C
$ 

Please modify the above script to repro your issue.

[ajith92]

The issue occurs for the getters of child schema. Code for the same is below

const assert = require('assert');
const mongoose = require('mongoose');
mongoose.set('debug', true);

const GITHUB_ISSUE = `gh7442`;
const connectionString = `mongodb://localhost:27017/${ GITHUB_ISSUE }`;
const { Schema } = mongoose;

run().then(() => console.log('done')).catch(error => console.error(error.stack));

async function run() {
  await mongoose.connect(connectionString, { useNewUrlParser: true });
  await mongoose.connection.dropDatabase();

  const childSchema = new Schema({
    value: {
      type: String,
      get: function(v) {
        console.log('Getters called')
        return v
      }
    },
    status: {
      type: String
    }
  }, {
    _id: 1
  })

  const schema = new Schema({
    name: {
      type: childSchema,
    }
  });
  const Model = mongoose.model('gh7442', schema);

  const doc = new Model({ 'name.value': 'test' });

  console.log('-------');

  doc.toObject();

  console.log('-------');

  doc.toObject({ getters: true });
}

Output:

Getters called
-------
-------
Getters called
Getters called
done