Harden Image Check In Media Library #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anigeluk
approved these changes
Mar 25, 2020
There was a problem hiding this comment.
Your PR has passed VIP code review. You can now merge into master to deploy when you are ready. Find out more in our documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #651, if the media library contains a recently uploaded asset with no thumbnail, the image upload UI breaks completely. This PR resolves the issue by hardening the check to be sure that the image object has sizes defined.
Fixes: #651
How to test the changes in this Pull Request:
masterbranch, view published Liveblog page, and click Insert Image.