Cache future timestamps for a short time #542
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of sending nocache headers, which has implications for cache servers like Varnish that do
hit-for-pass
, set a short TTL so the content can be served from cache, but expires when the timestamp becomes valid.Example of the problem (using Varnish as an example):
hit-for-pass
caching for 10 secondsnocache_headers()
which sets the max-age to 0 and a 1984 Expires headerhit-for-pass
hit-for-pass
TTL expires)This is obviously very problematic because it means one client requesting a (just barely) invalid timestamp can cause 100% of traffic (for that Varnish server) to bypass Varnish and hit the origin for a period of time.
After this change, the above scenario looks like this:
hit-for-pass
caching for 10 seconds