Move is_robot function to javascript #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Liveblog is currently reyling on an existence of `vary_cache_on_function` function when modifying the behaviour for bots. As not all environments taking advantage of page level caching have the posibility of varying page cache on user agent, the check should happen in browser. This commit it moving the logic to inside the js/liveblog-lazyloader.js taking advantage of the same regex and disabling the lazyloading initialisation for robots + hiding the load more button.
sboisvert
previously approved these changes
Jan 15, 2018
|
With the new React frontend I'm wondering whether we actually need this at all? |
philipjohn
previously approved these changes
Jun 5, 2018
philipjohn
dismissed stale reviews from sboisvert, ghost
, and themself
via
de1ddcf
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Liveblog is currently reyling on an existence of
vary_cache_on_functionfunction when modifying the behaviour for bots.As not all environments taking advantage of page level caching have the posibility of varying page cache on user agent, the check should happen in browser.
This commit it moving the logic to inside the js/liveblog-lazyloader.js taking advantage of the same regex and disabling the lazyloading initialisation for robots + hiding the load more button.
Fixes #264