Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing / Minileven: fix translation functions #9

Closed
wants to merge 1 commit into from

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Dec 18, 2013

props @deckerweb

2 Textdomains were missing context/ context translation functions

More information here:
http://plugins.trac.wordpress.org/ticket/2088

props @deckerweb

2 Textdomains were missing context/ context translation function
More information here:
http://plugins.trac.wordpress.org/ticket/2088
@georgestephanis
Copy link
Member

The minileven fix I believe should be textdomained as minileven to match the other minileven template files. Probably an old oversight, but likely worth fixing and then migrating upstream to the WordPress.com Sources.

@jeherve
Copy link
Member Author

jeherve commented Dec 30, 2013

The minileven fix I believe should be textdomained as minileven to match the other minileven template files.

We switched to jetpack for all minileven strings in r603288-plugins, so my patch should be ok. I already committed it upstream (ref. 15914).

georgestephanis added a commit that referenced this pull request Jan 1, 2014
Translation function should use context function.
See #9
Props @jeherve, @deckerweb
georgestephanis added a commit that referenced this pull request Jan 1, 2014
@jeherve jeherve closed this Jan 2, 2014
@jeherve jeherve deleted the 2088-trac branch January 2, 2014 08:38
tbradsha pushed a commit that referenced this pull request Apr 17, 2024
…genericons

Update/add codepoints to match genericons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Mobile Theme aka minileven [Feature] Sharing Post sharing, sharing buttons [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants