Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing: decode HTML entities in post titles #65

Merged
merged 2 commits into from
Jan 15, 2014
Merged

Sharing: decode HTML entities in post titles #65

merged 2 commits into from
Jan 15, 2014

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Jan 10, 2014

In my tests, it fixes #61.

I originally wanted to use wp_kses_decode_entities, but it only decodes numeric HTML entities. (ref)

@georgestephanis
Copy link
Member

This may be better to do inside get_share_title() in the parent class so it hits all services.

@jeherve jeherve mentioned this pull request Jan 15, 2014
Closed
blobaugh added a commit that referenced this pull request Jan 15, 2014
@blobaugh
Merge pull request #65 from jeherve/61
cefa699 
Sharing: decode HTML entities in post titles
@blobaugh blobaugh merged commit cefa699 into Automattic:master Jan 15, 2014
@blobaugh blobaugh deleted the 61 branch January 15, 2014 09:24
@blobaugh blobaugh mentioned this pull request Jan 15, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Feature] Sharing Post sharing, sharing buttons [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.

Sharing: Sharing a post with & in the title sends an encoded value
3 participants
@jeherve @georgestephanis @blobaugh