-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repo Gardening: log failures to send Slack messages #40369
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
Fixes #40366 Until now, we used to try to send messages to Slack, and didn't do anything if the message could not be sent. We'll now log the message, either by sending a Slack message to myself, or the Quality team for folks outside of the Automattic organization. This will allow us to better detect triage Slack actions that could not be completed, because a team no longer exists and their Slack channel has been archived for example. This also changes the Slack messaging utility to use Slack's own package instead of fetch, to give us more access to Slack's error management tools.
34c2612
to
4309982
Compare
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no problems with this, except I don't know how to test it. But you have probably done it yourself.
projects/github-actions/repo-gardening/src/utils/slack/send-slack-message.js
Show resolved
Hide resolved
// Let's send a direct message to @jeherve about it, so we can investigate. | ||
// For folks outside of Automattic, let's use the Quality team channel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not send all to the channel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's what we'll end up doing on the long term, but for now I'd like to monitor the assignment list closely, especially as more teams get re-orged.
See #40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com>
See #40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com>
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12124006031 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12123961622 Upstream-Ref: Automattic/jetpack@30b1275
See Automattic/jetpack#40369 (comment) Co-authored-by: anomiex <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12123961622 Upstream-Ref: Automattic/jetpack@30b1275
Fixes #40366
Proposed changes:
Until now, we used to try to send messages to Slack, and didn't do anything if the message could not be sent. We'll now log the message, either by sending a Slack message to myself, or the Quality team for folks outside of the Automattic organization.
This will allow us to better detect triage Slack actions that could not be completed, because a team no longer exists and their Slack channel has been archived for example.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
No
Testing instructions:
This can be tested in a fork. Here is an example:
jeherve#187
Here is the resulting message: p1732803634693709-slack-CN2FSK7L4