Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super Cache: Make sure plugin links is an array before using it #37604

Merged
merged 4 commits into from
Jun 13, 2024

Conversation

donnchawp
Copy link
Contributor

@donnchawp donnchawp commented May 28, 2024

It was reported that adding the Settings link to the plugins links on the Plugins page caused an error for a user because $links was null. This patch checks to make sure that $links is actually an array before using it.

Fixes #37600

Proposed changes:

  • Check that $links is an array

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Apply PR
You may need to adjust the path to wp-cache.php in the PR to match how you have WPSC installed. It may be installed in wp-super-cache-dev or super-cache.
Load Plugins page and note the links below the WP Super Cache title.

I can't reproduce this error, but this one line fix should fix it.

@donnchawp donnchawp added [Status] Needs Team Review [Plugin] Super Cache A fast caching plugin for WordPress. labels May 28, 2024
@donnchawp donnchawp self-assigned this May 28, 2024
@donnchawp donnchawp requested a review from a team May 28, 2024 15:10
Copy link
Contributor

github-actions bot commented May 28, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Super Cache plugin:

  • Next scheduled release: July 2, 2024.
  • Scheduled code freeze: June 24, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Contributor

@pkuliga pkuliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dilirity dilirity enabled auto-merge (squash) June 13, 2024 13:33
@dilirity dilirity merged commit a612be4 into trunk Jun 13, 2024
53 checks passed
@dilirity dilirity deleted the fix/super-cache/plugin-links branch June 13, 2024 13:41
@github-actions github-actions bot added this to the super-cache/1.12.1 milestone Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Super Cache A fast caching plugin for WordPress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Super Cache: check that plugin links is an array before adding Settings link
3 participants