Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Try faking a connection in plugin update test #36304

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Mar 9, 2024

Proposed changes:

We've had some cases where problematic code didn't trigger during the test because it needs the site to be connected.

PR #35911 suggests a way to fake the connection. We can't really use that directly since we want the code for all plugins, not just Jetpack-the-plugin, but we can copy-paste the relevant bit of code into the test script.

Also, while we're at it, let's run each test with a clean copy of the database.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1705092068241859-slack-CBG1CP4EN

Does this pull request change what data or activity we track or use?

No

Testing instructions:

We've had some cases where problematic code didn't trigger during the
test because it needs the site to be connected.

PR #35911 suggests a way to fake the connection. We can't really use
that directly since we want the code for all plugins, not just
Jetpack-the-plugin, but we can copy-paste the relevant bit of code into
the test script.

Also, while we're at it, let's run each test with a clean copy of the
database.
@anomiex anomiex added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress [Pri] Normal labels Mar 9, 2024
@anomiex anomiex requested review from sergeymitr and a team March 9, 2024 01:13
@anomiex anomiex self-assigned this Mar 9, 2024
@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Mar 9, 2024
Copy link
Contributor

github-actions bot commented Mar 9, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@anomiex anomiex added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] In Progress labels Mar 11, 2024
Copy link
Member

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can only really test this when we have plugins that need to be built. Let's try it!

@anomiex anomiex merged commit 9e91f5f into trunk Mar 18, 2024
53 checks passed
@anomiex anomiex deleted the try/ci-post-upgrade-mock-connection branch March 18, 2024 16:49
@github-actions github-actions bot removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions GitHub actions used to automate some of the work around releases and repository management [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants