Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Management: Tracking events #35773

Merged
merged 32 commits into from
Feb 28, 2024
Merged

Conversation

escapemanuele
Copy link
Contributor

@escapemanuele escapemanuele commented Feb 20, 2024

Fixes Automattic/wp-calypso#87608

Proposed changes:

Add tracking events for User management, /wp-admin/users.php, SSO changes.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Sync to Atomic site
  • Navigate to /wp-admins/users.php.
  • Trigger the SSO user actions (Revoke Invite, Send Invite) and add a new user.
  • Navigate to the Tracks Live View (MC: /tracks/live/) , filter by your username, and verify the events are being tracked correctly.

@escapemanuele escapemanuele added [Feature] SSO [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Feb 20, 2024
Copy link
Contributor

github-actions bot commented Feb 20, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/user-management-tracking branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/user-management-tracking
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for March 5, 2024 (scheduled code freeze on March 4, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@agrullon95
Copy link
Contributor

agrullon95 commented Feb 20, 2024

I updated the PR to only rely on a single instance of the tracking object and added tracking to other areas where we have relevant user actions.

The events are not properly tracked on my WoA as of now (more context: p1708469267317199/1708434623.948299-slack-CDLH4C1UZ), but I'm still looking into a solution.

@agrullon95 agrullon95 marked this pull request as ready for review February 23, 2024 19:34
} else {
$custom_message_sent = isset( $new_user_request['message'] ) ? 'true' : 'false';
self::$tracking->record_user_event(
'sso_user_new_user_invite_send',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use a different name for this event or this one is ok?
Its a bit confusing when you read it

'_wpnonce' => $nonce,
);

self::$tracking->record_user_event(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this

Copy link
Contributor

@heavyweight heavyweight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can verify that the events are sent out

@agrullon95 agrullon95 merged commit f1c6ccb into trunk Feb 28, 2024
54 checks passed
@agrullon95 agrullon95 deleted the update/user-management-tracking branch February 28, 2024 01:38
@github-actions github-actions bot added this to the jetpack/13.2 milestone Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] SSO [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User management: Improve tracking
3 participants