Repo Gardening: change the order of the tasks running #35723
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
We currently have 2 different tasks that can trigger Slack Notifications:
triageIssues
updateBoard
Both of those tasks rely on the
notifyImportantIssues
utility function to post to Slack. That utility, after posting a message to Slack, adds a label ("[Status] Priority Review Triggered") to ensure that we do not post to Slack multiple times.As a result, the 2 tasks above cannot both post to Slack: the one that runs first does, and the other one bails because the label already exists.
I think the
updateBoard
task should take prriority, since it warns the team working on the product directly, while thetriageIssues
task "only" warns triage teams that will in turn contact the product teams if necessary.As a result, I'd like the Board update task to run first, before issues get triaged, so that the Slack notifications potentially triggered by the board update task happen first, before the Slack notifications sent by the triageIssues task.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
This cannot be tested in this repo before the PR is merged. It can only be tested in a fork.