Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo Gardening: change the order of the tasks running #35723

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Feb 16, 2024

Proposed changes:

We currently have 2 different tasks that can trigger Slack Notifications:

  • triageIssues
  • updateBoard

Both of those tasks rely on the notifyImportantIssues utility function to post to Slack. That utility, after posting a message to Slack, adds a label ("[Status] Priority Review Triggered") to ensure that we do not post to Slack multiple times.

As a result, the 2 tasks above cannot both post to Slack: the one that runs first does, and the other one bails because the label already exists.

I think the updateBoard task should take prriority, since it warns the team working on the product directly, while the triageIssues task "only" warns triage teams that will in turn contact the product teams if necessary.

As a result, I'd like the Board update task to run first, before issues get triaged, so that the Slack notifications potentially triggered by the board update task happen first, before the Slack notifications sent by the triageIssues task.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

This cannot be tested in this repo before the PR is merged. It can only be tested in a fork.

I'd like the Board update task to run first, before issues get triaged, so that the Slack notifications potentially triggered by the board update task happen first, before the Slack notifications sent by the triageIssues task.
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Pri] Normal [Status] Needs Team Review [Action] Repo Gardening Github Action: manage PR and issues in your Open Source project labels Feb 16, 2024
@jeherve jeherve requested a review from a team February 16, 2024 10:01
@jeherve jeherve self-assigned this Feb 16, 2024
@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Feb 16, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Copy link
Contributor

@monsieur-z monsieur-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward enough 👍

@jeherve jeherve merged commit 4652fe6 into trunk Feb 16, 2024
53 checks passed
@jeherve jeherve deleted the update/repo-gardening-task-order branch February 16, 2024 18:05
@github-actions github-actions bot removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Status] Needs Team Review labels Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Action] Repo Gardening Github Action: manage PR and issues in your Open Source project Actions GitHub actions used to automate some of the work around releases and repository management [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants