Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dotcom Patterns: Register wp_block patterns from Dotcompatterns with blockTypes #35337

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

miksansegundo
Copy link
Contributor

@miksansegundo miksansegundo commented Jan 30, 2024

Related Automattic/wp-calypso#78478

Proposed changes:

  • Register wp_block patterns from Dotcompatterns with blockTypes
BEFORE AFTER
Screenshot 2567-01-30 at 21 10 57 Screenshot 2567-01-30 at 21 12 01

Pattern BlockTypes

Header/Footer Replace Template Part
Footer.and.headers.mov
Add Query Loop Block
Query.loop.mov

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Sandbox a site and the public api
  • Apply this PR following the instructions on the bot comment below
  • Make sure your site has the Assembler theme active
    • Access the editor, open the pattern inserter, and check that you can see the wp_block patterns from Dotcompatterns, not from Assemblerv2patterns
    • Select the Header template part, open the three-dots menus and click "Replace" to confirm you see the new patterns
    • Select the Footer template part, open the three-dots menus and click "Replace" to confirm you see the new patterns
    • Add a Query Loop block, click "Choose" to confirm you see the new patterns
  • When the site doesn't use the Assembler theme but still sandboxed, verify that the patterns are the same as on production. See video:
Screen.Recording.2567-01-30.at.21.03.09.mov

@miksansegundo miksansegundo requested a review from a team January 30, 2024 14:25
@miksansegundo miksansegundo self-assigned this Jan 30, 2024
Copy link
Contributor

github-actions bot commented Jan 30, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the chore/register-wp-block-pattern-block-types branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin chore/register-wp-block-pattern-block-types
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Jan 30, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Mu Wpcom plugin:

  • Next scheduled release: February 6, 2024.
  • Scheduled code freeze: January 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 30, 2024
@miksansegundo miksansegundo added [Status] Needs Team Review and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Package] Jetpack mu wpcom WordPress.com Features [mu wpcom Feature] Block Patterns labels Jan 30, 2024
@miksansegundo miksansegundo force-pushed the chore/register-wp-block-pattern-block-types branch from 200078d to e1b69ba Compare January 30, 2024 14:36
@github-actions github-actions bot added the [Plugin] mu wpcom jetpack-mu-wpcom plugin label Jan 30, 2024
@miksansegundo miksansegundo force-pushed the chore/register-wp-block-pattern-block-types branch from 2024634 to 1315188 Compare January 30, 2024 14:54
@miksansegundo miksansegundo merged commit 948b3dd into trunk Jan 30, 2024
52 checks passed
@miksansegundo miksansegundo deleted the chore/register-wp-block-pattern-block-types branch January 30, 2024 15:42
robfelty pushed a commit that referenced this pull request Jan 31, 2024
…blockTypes (#35337)

* Register wp_block patterns from Dotcompatterns with blockTypes

* changelog

* Update project version

* Updated composer lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants