Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Page: avoid react warning with VideoPress card #34713

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Admin Page: avoid react warning with VideoPress card #34713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions projects/plugins/jetpack/_inc/client/at-a-glance/videopress.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,7 @@ class DashVideoPress extends Component {
className="jp-dash-item__is-inactive"
noToggle={ ! hasConnectedOwner }
overrideContent={
! hasConnectedOwner &&
! isOffline && (
! hasConnectedOwner && ! isOffline ? (
<JetpackBanner
callToAction={ __( 'Connect', 'jetpack' ) }
title={ __(
Expand All @@ -143,7 +142,7 @@ class DashVideoPress extends Component {
plan={ getJetpackProductUpsellByFeature( FEATURE_VIDEOPRESS ) }
icon="video"
/>
)
) : null
}
>
<p className="jp-dash-item__description">
Expand Down
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/fix-warning-videopress-card
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: other

Dashboard: avoid React warning when loading the VideoPress card.
Loading