Subscriptions: fix reach count above 1000 in editor pre- & post-publish panel

[simison]

Fixes issues where subscription reach counts above 1000 in some locales (e.g. en-US) would cause translations return as "%d subscribers", as they add thousand-delimiters like comma or empty space, turning the number into a string.

Before

After

Context & examples

Issue is caused by .toLocaleString() in one of lines handling the numbers. Issue does not show up if you have less than 1000 subscribers, or use a locale that doesn't add commas or spacing as thousands-separator, like Spanish.

EN-US locale, 1000 and 10 — 1000 breaks, but 10 works with %d placholder:

wp.i18n.sprintf('test %d', (10).toLocaleString());
"test 10"

wp.i18n.sprintf('test %d', (1000).toLocaleString('en-US'));
sprintf error: 

TypeError: [sprintf] expecting number but found string
"test %d"

Spanish locale 1000 works with %d as placeholder:

wp.i18n.sprintf('test %d', (1000).toLocaleString('es'));
"test 1000"

EN-US locale, 1000 works with %s placeholder:

wp.i18n.sprintf('test %s', (1000).toLocaleString());
"test 1,000" 

Proposed changes:

• Allows strings in translation strings. Ensures reachCount is consistently a Number, and convert it to string for localization.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Either have a site with 1000+ subscribers, or mock the number at getReachForAccessLevelKey():
  

  jetpack/projects/plugins/jetpack/extensions/shared/memberships/settings.js

  Lines 41 to 48 in 93aa805

  	export function getReachForAccessLevelKey( {
  	accessLevel,
  	emailSubscribers,
  	paidSubscribers,
  	postHasPaywallBlock = false,
  	} ) {
  	emailSubscribers = emailSubscribers ?? 0;
  	paidSubscribers = paidSubscribers ?? 0;

• Create a post, and publish. See string work correctly in pre- and post-publish panels.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/subscription-reach-count branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack fix/subscription-reach-count
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for January 9, 2024 (scheduled code freeze on January 8, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.