Split `PublicizeForm` component #34612

manzoorwanijk · 2023-12-13T08:54:04Z

Proposed changes:

This PR breaks down PublicizeForm component into smaller ones

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Run jetpack build --all
Goto post editor
Confirm that everything is same as before

…hared if they will get over limits. (#34183) * Enhance RecordBarMeter component with `className` * Add changelog * Add store types * Update store selectors and actions * Update consumer hook to use new selectors * Create useShareLimits hook * Move `ShareCounter` to publicize-components and name it `ShareLimitsBar` * Create separate notice components * Fix the post editor notices * Update Jetpack Social admin page to use the new meter bar * Remove unused code left after #34111 * Add changelog * Fix share count * Update index.js * Include active connections count for notices * Fix i18n build error * Enhance RecordBarMeter component with `className` * Add changelog * Extract constants and improve types * Extract messages to utility function * Enhance RecordBarMeter component with `className` * Add changelog * Fix up versions * Revert "Remove unused code left after #34111" This reverts commit ca45999. * Use @wordpress/element instead of react * Fix messaging * Let TS infer type * Combine the share limits logic into a single useSelect call * Fix the limits shown even after a paid plan

* Enhance RecordBarMeter component with `className` * Add changelog * Add store types * Update store selectors and actions * Update consumer hook to use new selectors * Create useShareLimits hook * Move `ShareCounter` to publicize-components and name it `ShareLimitsBar` * Create separate notice components * Fix the post editor notices * Update Jetpack Social admin page to use the new meter bar * Remove unused code left after #34111 * Add changelog * Fix share count * Update index.js * Include active connections count for notices * Fix i18n build error * Enhance RecordBarMeter component with `className` * Add changelog * Extract constants and improve types * Add types/jest * Add tests for sharesData selectors * Add tests for useShareLimits hook * rename to *.test.js * extract utility * Create add-tests-for-sharing-data * Update shares-data.test.js * Extract messages to utility function * Use the messages from utility function * Enhance RecordBarMeter component with `className` * Add changelog * Fix up versions * Revert "Remove unused code left after #34111" This reverts commit ca45999. * Use @wordpress/element instead of react * Fix messaging * Let TS infer type * Combine the share limits logic into a single useSelect call * Fix the limits shown even after a paid plan * Enhance RecordBarMeter component with `className` * Add changelog * Enhance RecordBarMeter component with `className` * Add changelog * Jetpack Social | Warn the user that their scheduled posts won't get shared if they will get over limits. (#34183) * Enhance RecordBarMeter component with `className` * Add changelog * Add store types * Update store selectors and actions * Update consumer hook to use new selectors * Create useShareLimits hook * Move `ShareCounter` to publicize-components and name it `ShareLimitsBar` * Create separate notice components * Fix the post editor notices * Update Jetpack Social admin page to use the new meter bar * Remove unused code left after #34111 * Add changelog * Fix share count * Update index.js * Include active connections count for notices * Fix i18n build error * Enhance RecordBarMeter component with `className` * Add changelog * Extract constants and improve types * Extract messages to utility function * Enhance RecordBarMeter component with `className` * Add changelog * Fix up versions * Revert "Remove unused code left after #34111" This reverts commit ca45999. * Use @wordpress/element instead of react * Fix messaging * Let TS infer type * Combine the share limits logic into a single useSelect call * Fix the limits shown even after a paid plan * Update tests

* Update store selectors and resolvers to save initial connections * Update useShareLimits hook to subtract scheduled post if editing one * Update ShareCountInfo to subtract the scheduled post from count * Add changelog * Fix versions * changelog!!!!

…hared if they will get over limits. (#34183) * Enhance RecordBarMeter component with `className` * Add changelog * Add store types * Update store selectors and actions * Update consumer hook to use new selectors * Create useShareLimits hook * Move `ShareCounter` to publicize-components and name it `ShareLimitsBar` * Create separate notice components * Fix the post editor notices * Update Jetpack Social admin page to use the new meter bar * Remove unused code left after #34111 * Add changelog * Fix share count * Update index.js * Include active connections count for notices * Fix i18n build error * Enhance RecordBarMeter component with `className` * Add changelog * Extract constants and improve types * Extract messages to utility function * Enhance RecordBarMeter component with `className` * Add changelog * Fix up versions * Revert "Remove unused code left after #34111" This reverts commit ca45999. * Use @wordpress/element instead of react * Fix messaging * Let TS infer type * Combine the share limits logic into a single useSelect call * Fix the limits shown even after a paid plan

github-actions · 2023-12-13T08:55:22Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Social plugin:

Next scheduled release: January 2, 2024.
Scheduled code freeze: December 25, 2023.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions · 2023-12-13T08:55:51Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/split-publicize-form-component branch.
- For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/split-publicize-form-component

bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/split-publicize-form-component

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

pablinos

This works well. It's a little hard to tell if anything has crept as the code is moved to separate components, but it looks like a straight copy, which is great. We can continue to improve it in updates.

projects/js-packages/publicize-components/src/components/form/instagram-supported-notice.tsx

projects/js-packages/publicize-components/src/components/form/advanced-plan-nudge.tsx

anomiex · 2023-12-18T17:17:38Z

pnpm-lock.yaml

    dev: false

-  /@adobe/css-tools@4.3.2:
-    resolution: {integrity: sha512-DA5a1C0gD/pLOvhv33YMrbf2FK3oUzwNl9oOJqE4XVjuEtt6XIakRcsd7eLiOSPkp1kTRQGICTA8cKra/vFbjw==}
+  /@adobe/css-tools@4.3.1:


It's unfortunate this was downgraded in this PR, as version 4.3.2 includes a security fix. See https://github.com/Automattic/jetpack/security/dependabot/65

I'm sure it happened due to a merge conflict and regenerating the lockfile.

manzoorwanijk added 14 commits December 13, 2023 14:01

Fix up versions

3a41a53

Delete unused PublicizePanel component

01d6699

Create smaller components out of PublicizeForm

82e8c1b

Use the newly created smaller components in PublicizeForm

63d5488

Update types.ts

392dac3

Fix jsdocs

ab60f28

Fix up versions

a24e9c2

changelog

5872e9e

Clean up PublicizeForm consumer component

f56788b

Restore changes messed up in rebase

0c9dab5

manzoorwanijk added the [Status] Needs Team Review label Dec 13, 2023

manzoorwanijk requested a review from a team December 13, 2023 08:54

manzoorwanijk self-assigned this Dec 13, 2023

github-actions bot added [JS Package] Publicize Components [Plugin] Social Issues about the Jetpack Social plugin RNA labels Dec 13, 2023

Restore description

6a2d476

manzoorwanijk force-pushed the update/split-publicize-form-component branch from e4ef3ee to 6a2d476 Compare December 13, 2023 09:02

manzoorwanijk added 2 commits December 13, 2023 14:49

Fix types

75cd2b7

Fix types for test written in TS

0ef52e5

manzoorwanijk changed the title ~~Breakdown PublicizeForm component~~ Split PublicizeForm component Dec 13, 2023

Merge branch 'trunk' into update/split-publicize-form-component

1f1c84a

pablinos approved these changes Dec 14, 2023

View reviewed changes

projects/js-packages/publicize-components/src/components/form/instagram-supported-notice.tsx Show resolved Hide resolved

projects/js-packages/publicize-components/src/components/form/advanced-plan-nudge.tsx Show resolved Hide resolved

manzoorwanijk merged commit a8efe5a into trunk Dec 14, 2023
65 checks passed

manzoorwanijk deleted the update/split-publicize-form-component branch December 14, 2023 08:20

github-actions bot removed the [Status] Needs Team Review label Dec 14, 2023

anomiex reviewed Dec 18, 2023

View reviewed changes

manzoorwanijk mentioned this pull request Dec 20, 2023

Social | Fix the media validation notice shown even when auto conversion is eabled #34730

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Split `PublicizeForm` component #34612

Split `PublicizeForm` component #34612

manzoorwanijk commented Dec 13, 2023

github-actions bot commented Dec 13, 2023

github-actions bot commented Dec 13, 2023 •

edited

Loading

pablinos left a comment

anomiex Dec 18, 2023

manzoorwanijk Dec 18, 2023

Split PublicizeForm component #34612

Split PublicizeForm component #34612

Conversation

manzoorwanijk commented Dec 13, 2023

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Dec 13, 2023

github-actions bot commented Dec 13, 2023 • edited Loading

pablinos left a comment

Choose a reason for hiding this comment

anomiex Dec 18, 2023

Choose a reason for hiding this comment

manzoorwanijk Dec 18, 2023

Choose a reason for hiding this comment

Split `PublicizeForm` component #34612

Split `PublicizeForm` component #34612

github-actions bot commented Dec 13, 2023 •

edited

Loading