Launchpad: Add sensei setup task

[valterlorran]

Related to: #34320
More context: paYKcK-3Hy-p2

Proposed changes:

• As part of the migration from the Site Setup Checklist to the Launchpad, we need to reproduce the logic of the legacy task so we can enable the Launchpad to be used for new sites only.
• This PR adds the Sensei Setup task to the Legacy Site Setup checklist and also the visibility logic.
• The completion logic will be tackled in another PR.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Apply this PR to your sandbox using the command below.

bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/launchpad-sensei-setup-task

• Create a new site through the /setup/free flow, and then add the Business plan
• Once you reach the Customer Home, go to the Developer Console and make a GET request to wpcom/v2 -> /sites/:siteSlug/launchpad?checklist_slug=legacy-site-setup
• Make sure the Finish Sensei setup task is not shown

• Now, add your site to the WoA Developer list.
• Then, install the Sensei LMS plugin, which should change your site to Atomic.
• Use the Jetpack Beta plugin to apply this PR to your site(You may have to updated the files manually, as the plugin doesn't seem to work on my end)
• Go back to the Developer Console and make the request again. Now you should see the Finish Sensei setup task in the response.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/launchpad-sensei-setup-task branch.

  • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/launchpad-sensei-setup-task
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Mu Wpcom plugin:

• Next scheduled release: January 2, 2024.
• Scheduled code freeze: December 25, 2023.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[markbiek]

Working as expected!

[markbiek]

Would it be a little cleaner to use is_plugin_active instead? Not sure if that will work in this context.

[valterlorran]

In this case, the option actually returns all the active plugins. Perhaps it would be clearer if we did something like:

Suggested change

	$active_plugins = get_option( 'active_plugins' );
	$active_plugins = get_option( 'active_plugins' );
	$is_sensei_active = in_array( 'sensei-lms/sensei-lms.php', $active_plugins, true );
	return $is_sensei_active;

WDYT?

[markbiek]

What I'm wondering is, can we do this?

return is_plugin_active( 'sensei-lms/sensei-lms.php' ); 

Then we can avoid calling get_option entirely. Again, I'm not sure if this is possible but i was curious because it would

[valterlorran]

Oh, great! I didn't know about this function, but I will try to use it.

[markbiek]

LGTM!