Jetpack Social | Fix admin page connections UI

[manzoorwanijk]

In #34064, we made some changes to the store and thus admin page doesn't know anything about the connections and it always says "Connect accounts" even if there are accounts connected.

Proposed changes:

• Update the admin header to feed it the data from initial state.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Install Jetpack Social - jetpack install plugins/social
• Remove all the Social Media connections for the site
• Goto Social admin page - /wp-admin/admin.php?page=jetpack-social
• Confirm that you see the "Connect accounts" button
• Now connect one or more social media accounts for the site
• Reload the admin page
• Confirm that you no longer see the "Connect accounts" button

BEFORE	AFTER

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Social plugin:

• Next scheduled release: December 5, 2023.
• Scheduled code freeze: November 27, 2023.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[pablinos]

This fixes it!

[pablinos]

@jeffgolenski and/or @ilonagl - Looking at the 'After' screenshot above. Do you think the 'Write a Post' button should become primary once the site has connections? Initially the primary CTA is to connect networks, but after that we want people to write things to share, and the admin page has no primary CTA in this state.

[ilonagl]

@jeffgolenski and/or @ilonagl - Looking at the 'After' screenshot above. Do you think the 'Write a Post' button should become primary once the site has connections? Initially the primary CTA is to connect networks, but after that we want people to write things to share, and the admin page has no primary CTA in this state.

Yes, making that button primary would be the best approach! It helps to guide user's actions.

[jeffgolenski]

Good eye, Paul! Yes sir!

[manzoorwanijk]

@pablinos I have created a task for that which you can see mentioned above.