Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI Client: change AI control shadow depth #34362

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

CGastrell
Copy link
Contributor

@CGastrell CGastrell commented Nov 29, 2023

Adjust AI Assistant shadow for a better sense of depth and decoupling

Fixes #34331

Proposed changes:

This PR changes the shadow to match the designs seen on Figma file: gG1smMHbNGas0qwP9y6RwK-fi-7531%3A1227

image

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1701184924339369-slack-C02TQF5VAJD
p1HpG7-pBB-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Use the link to create a JN instance, go to editor and create an AI Assistant block, see the new shadows match those in designs

@CGastrell CGastrell added [Status] Needs Design Review Design has been added. Needs a review! [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Block] AI Assistant [JS Package] AI Client labels Nov 29, 2023
@CGastrell CGastrell requested review from madebynoam, ederrengifo and a team November 29, 2023 14:10
@CGastrell CGastrell self-assigned this Nov 29, 2023
Copy link
Contributor

github-actions bot commented Nov 29, 2023

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the change/ai-control-shadow-depth branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack change/ai-control-shadow-depth
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added the RNA label Nov 29, 2023
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for December 5, 2023 (scheduled code freeze on November 28, 2023).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@@ -83,12 +83,12 @@
display: flex;
align-items: center;
justify-content: center;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Contributor

@dhasilva dhasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before After
2023-11-29_16-09-14-before 2023-11-29_16-09-28-after

The shadow is not visible on themes with black backgrounds, but there is nothing that can be done in that regard.

Copy link

@ederrengifo ederrengifo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CGastrell CGastrell merged commit 44f5a12 into trunk Nov 29, 2023
52 checks passed
@CGastrell CGastrell deleted the change/ai-control-shadow-depth branch November 29, 2023 19:57
@github-actions github-actions bot added this to the jetpack/12.9 milestone Nov 29, 2023
@CGastrell CGastrell mentioned this pull request Nov 29, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] AI Assistant [JS Package] AI Client [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ RNA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI Assistant: block shadow should follow design guides for proper floating tool depth
3 participants