Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Subscriptions] Add/redirect url once token is set in cookie #33437

Merged
merged 4 commits into from
Oct 7, 2023

Conversation

millerf
Copy link
Contributor

@millerf millerf commented Oct 2, 2023

Follow-up on this comment: https://github.com/Automattic/gold/issues/36#issuecomment-1735025461 and 6719026-zen

Content creators are complaining the access token is available and could eventually be shared amongst users.

This PR tries to fix it by reloading the page once it is saved in the session (cookie).

Proposed changes:

  • Redirect to the sae URL without the token param once it is set

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Subscribe to any test site and notice the "token" in the URL when coming back from payment
  • Reloading the page should keep the param
Screenshot 2023-10-02 at 16 29 39
  • Patch this on your sandbox (or use this branch on Jetpack beta) and reload the page
    => the URL should now be without "token"
    => you should still have access to the content
Screenshot 2023-10-02 at 16 38 05

@millerf millerf changed the title [Subscriptions[ Add/redirect url once token is set in cookie [Subscriptions] Add/redirect url once token is set in cookie Oct 2, 2023
@github-actions github-actions bot added [Block] Paid Content aka Premium Content [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Oct 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

  • Next scheduled release: October 10, 2023.
  • Scheduled code freeze: October 9, 2023.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Oct 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/redirect-url-once-token-in-cookie branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/redirect-url-once-token-in-cookie
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@millerf millerf added [Status] Needs Team Review and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Oct 2, 2023
@millerf millerf enabled auto-merge (squash) October 5, 2023 15:41
@millerf millerf self-assigned this Oct 7, 2023
Copy link
Contributor

@n3f n3f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM :shipit:

@millerf millerf merged commit 49859cf into trunk Oct 7, 2023
52 of 53 checks passed
@millerf millerf deleted the add/redirect-url-once-token-in-cookie branch October 7, 2023 16:08
@github-actions github-actions bot added this to the jetpack/12.7 milestone Oct 7, 2023
@kraftbj
Copy link
Contributor

kraftbj commented Oct 10, 2023

@ice9js did this get reverted per p1696930413601329/1696911339.732729-slack-C02FMH4G8 ?

@github-actions
Copy link
Contributor

Support References

This comment is automatically generated. Please do not edit it.

  • 6719026-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" label Oct 10, 2023
@ice9js
Copy link
Member

ice9js commented Oct 10, 2023

Not yet. It needs to be done manually hence the delay, I'm working on it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Paid Content aka Premium Content Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants