Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI Assistant: Mark post as AI-assisted #31304

Closed
wants to merge 3 commits into from

Conversation

lhkowalski
Copy link
Contributor

@lhkowalski lhkowalski commented Jun 9, 2023

Fixes #31235.

Proposed changes:

  • Register the _jetpack_ai_calls post meta field so we can expose and change it from Gutenberg
  • Change the block to update the _jetpack_ai_calls post meta field when a completion is requested
  • The name of the option is the same as the original one, from [Jetpack AI] Store post ids #28487

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to the block editor
  • On the browser console, run:
wp.data.select('core/editor').getEditedPostAttribute('meta');
  • It returns the list of post meta fields exposed on the rest API; notice the _jetpack_ai_calls field:
Screen Shot 2023-06-09 at 19 10 25
  • Add an AI Assistant block and execute some prompt (for example: "a haiku on the winter winds")
  • Run the getEditedPostAttribute command again
  • Notice that now the _jetpack_ai_calls got incremented
  • Save the post changes and reload the window
  • Run the getEditedPostAttribute command again
  • Notice that the value for the _jetpack_ai_calls post meta field got saved
  • If you are running your test site locally, you can spot the post meta field on the wp_postmeta table for the given post ID
  • If you are testing this for a Simple site, on your sandbox you can run the following commando to inspect the database value for the post meta fields
wp --url=YOUR_SITE_URL post meta list YOUR_POST_ID
  • Test on Jetpack sites and on Simple sites

Note: I didn't test this on p2 comments, so we may need to check this as well and maybe work around the comment box limitations.

@lhkowalski lhkowalski added [Status] In Progress [Size] S [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Block] AI Assistant labels Jun 9, 2023
@lhkowalski lhkowalski requested a review from a team June 9, 2023 22:08
@lhkowalski lhkowalski self-assigned this Jun 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack plugin. Once the plugin is active, go to Jetpack > Jetpack Beta > Jetpack and enable the add/ai-assistant-mark-post-as-ai-assisted branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/ai-assistant-mark-post-as-ai-assisted
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

  • Next scheduled release: July 5, 2023.
  • Scheduled code freeze: June 26, 2023.

@oskosk
Copy link
Contributor

oskosk commented Jun 10, 2023

Closing as we don't need it for now. Please see #31235 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] AI Assistant [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Size] S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI Assistant: mark posts with accepted AI content as AI assisted
2 participants