Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Android player controls #29990
[RNMobile] Android player controls #29990
Changes from 14 commits
7a5839e
c144a88
c1b5662
9e59021
4c51bb5
937ea9d
213f2c5
850139d
ebfe916
26d8150
ead3b29
722bd10
ebbdd5f
d801b7a
8454aba
455389e
3c024d3
ec07fea
97dd1d3
eb41925
8052a31
a415583
2a119e1
62b3add
cca47df
e4b69eb
80888eb
52053c9
6b29912
c35d99a
4905b22
c4d0115
732f7d9
fb35d68
b4311cc
8be5571
07e1395
83c0024
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I first started working on this, the
Player
was still a small component. It ballooned a bit more after I added the preview logic. Since the player controls are 1. Android only and 2. hopefully a temporary work around I opted to put as much of the logic into a separate component.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered passing the
playerRef
down to the control component but it got wonky trying to manage the events coming from the embed. I then decided to let thePlayer
continue to own the embed