Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack: Remove deprecated jetpack_require_lib and friends #28866

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Feb 9, 2023

Proposed changes:

We announced back in 11.6 that these were going to go away in 11.9. It's now time for 11.9, so let's remove them.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p9dueE-5EZ-p2
#27273

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Everything should continue to work.

We announced back in 11.6 that these were going to go away in 11.9. It's
now time for 11.9, so let's remove them.
@anomiex anomiex added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Pri] Normal labels Feb 9, 2023
@anomiex anomiex self-assigned this Feb 9, 2023
@anomiex anomiex enabled auto-merge (squash) February 9, 2023 14:57
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Feb 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: March 7, 2023.
  • Scheduled code freeze: February 28, 2023.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run

bin/jetpack-downloader test jetpack remove/deprecated-jetpack_require_lib

to get started. More details: p9dueE-5Nn-p2

@sergeymitr sergeymitr added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 9, 2023
@anomiex anomiex merged commit 28bf13b into trunk Feb 10, 2023
@anomiex anomiex deleted the remove/deprecated-jetpack_require_lib branch February 10, 2023 18:12
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 10, 2023
@github-actions github-actions bot added this to the jetpack/11.9 milestone Feb 10, 2023
dd32 added a commit to WordPress/wordcamp.org that referenced this pull request Mar 28, 2023
…sion.

Jetpack has removed `jetpack_require_lib()` in preference for direct file inclusions.

See Automattic/jetpack#28866
@mehdi-nexstar
Copy link

The alternative way of using libraries :
require_once JETPACK__PLUGIN_DIR . '_inc/lib/LIB_NAME';

pkevan pushed a commit to WordPress/wordcamp.org that referenced this pull request Jul 12, 2023
…sion. (#859)

Jetpack has removed `jetpack_require_lib()` in preference for direct file inclusions.

See Automattic/jetpack#28866
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants