Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paid newsletters fix warnings #28639

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Paid newsletters fix warnings #28639

merged 2 commits into from
Jan 30, 2023

Conversation

artpi
Copy link
Contributor

@artpi artpi commented Jan 30, 2023

More context in p1674830085351189-slack-CBG1CP4EN

Fixes the call where we would read the global $post without any protection against it being null

Proposed changes:

use get_the_ID() instead of the $post global

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Same as #28170

@artpi artpi requested review from jeherve and a team January 30, 2023 11:41
@github-actions github-actions bot added [Block] Subscriptions [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Jan 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: February 7, 2023.
  • Scheduled code freeze: January 31, 2023.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2023

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run

bin/jetpack-downloader test jetpack paid-newsletters-fix-warnings

to get started. More details: p9dueE-5Nn-p2

@artpi artpi added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 30, 2023
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! [Type] Bug When a feature is broken and / or not performing as intended [Pri] Normal and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jan 30, 2023
@artpi artpi merged commit c33ec2a into trunk Jan 30, 2023
@artpi artpi deleted the paid-newsletters-fix-warnings branch January 30, 2023 12:43
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jan 30, 2023
@github-actions github-actions bot added this to the jetpack/11.8 milestone Jan 30, 2023
pyronaur pushed a commit that referenced this pull request Feb 3, 2023
This fixes warnings introduced by unprotected `$post` global call introduced in #28170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Subscriptions [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants