[Super Cache] Ensure cron schedule is setup whenever the config changes #28545
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly related: https://wordpress.org/support/topic/empty-cache-directories/
When you set a preload schedule in wp-super-cache, the cron job was only being set up if one was already scheduled. If one wasn't for any reason, then it did not add one.
This PR changes the way that cronjobs are managed: Any time the settings are edited, it ensures that there is a cron if one should be there, and there isn't one if not. If the interval gets edited, then the cronjob gets destroyed (if it exists) and recreated.
Note: this will not schedule a cronjob if preload mode is not enabled. I wanted to verify with @donnchawp that's the correct / expected behaviour.
Proposed changes:
Other information:
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
no
Testing instructions: