Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Fix Ads Stats controller params #28544

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Conversation

kangzj
Copy link
Contributor

@kangzj kangzj commented Jan 24, 2023

Proposed changes:

Fixed missing params to be passed to WPCOM API. This is a follow up for #27791.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Enable WordAds - /wp-admin/admin.php?page=jetpack#/traffic?term=wordads
  • Open /wp-admin/admin.php?page=stats&flags=stats%2Fads-page
  • Switch period for the bar chart on Ads page
  • Ensure data look okay

@kangzj kangzj added [Feature] Stats Data Feature that enables users to track their site's traffic and gain insights on popular content. [Package] Stats Admin labels Jan 24, 2023
@kangzj kangzj requested a review from a team January 24, 2023 04:01
@kangzj kangzj self-assigned this Jan 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@kangzj kangzj marked this pull request as ready for review January 24, 2023 04:03
@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2023

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run bin/jetpack-downloader test jetpack fix/ads-controller-params to get started. More details: p9dueE-5Nn-p2

@wilmersondasilva
Copy link
Contributor

I tried to test this one, but unfortunately, I couldn't make the Ads page works properly.

Copy link
Contributor

@wilmersondasilva wilmersondasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to make it work now.

I noticed the bug while testing Automattic/wp-calypso#72360

This PR fixes the issue and works as expected. Thanks for fixing this @kangzj! 👍

@kangzj kangzj merged commit 7ea44ea into trunk Jan 25, 2023
@kangzj kangzj deleted the fix/ads-controller-params branch January 25, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Data Feature that enables users to track their site's traffic and gain insights on popular content. [Package] Stats Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants