Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Coverage: remove automation #28542

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Code Coverage: remove automation #28542

merged 2 commits into from
Jan 24, 2023

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Jan 24, 2023

We haven't used the code coverage tests in a long while (ever?), so let's remove it to save us some red Xs.

Proposed changes:

  • Remove Code Coverage automation

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Check CI

@kraftbj kraftbj self-assigned this Jan 24, 2023
@kraftbj kraftbj requested review from dereksmart and jeherve January 24, 2023 00:00
@kraftbj
Copy link
Contributor Author

kraftbj commented Jan 24, 2023

Marking as In Progress until confirming CI results.

@github-actions github-actions bot added [Tools] Development CLI The tools/cli to assist during JP development. Actions GitHub actions used to automate some of the work around releases and repository management labels Jan 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2023 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2023 •
edited
Loading

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run bin/jetpack-downloader test jetpack remove/codecov to get started. More details: p9dueE-5Nn-p2

@kraftbj kraftbj added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Jan 24, 2023
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jan 24, 2023
@jeherve jeherve enabled auto-merge (squash) January 24, 2023 09:22
@jeherve jeherve merged commit da5e788 into trunk Jan 24, 2023
@jeherve jeherve deleted the remove/codecov branch January 24, 2023 17:21
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jan 24, 2023
anomiex added a commit that referenced this pull request Feb 15, 2023
@anomiex
Remove remnants of automated code coverage support
2957416 
PR #28542 removed the calls to the coverage scripts (except for one
line), but didn't update the documentation, remove the scripts
themselves, or adjust `jetpack generate` to stop generating those
scripts. This does all that.
anomiex added a commit that referenced this pull request Feb 15, 2023
@anomiex
Remove remnants of automated code coverage support
9222250 
PR #28542 removed the calls to the coverage scripts (except for one
line), but didn't update the documentation, remove the scripts
themselves, or adjust `jetpack generate` to stop generating those
scripts. This does all that.

It does not remove the PHPUnit or Jest definitions of which files should
be looked at for coverage, or any `@codeCoverageIgnore` directives, or
the `test-coverage-html` script in packages/waf, as those may still be
useful for people manually looking at coverage locally.
@anomiex anomiex mentioned this pull request Feb 15, 2023
Merged
3 tasks
anomiex added a commit that referenced this pull request Feb 20, 2023
@anomiex
Remove remnants of automated code coverage support (#28982)
8cc3246 
PR #28542 removed the calls to the coverage scripts (except for one
line), but didn't update the documentation, remove the scripts
themselves, or adjust `jetpack generate` to stop generating those
scripts. This does all that.

It does not remove the PHPUnit or Jest definitions of which files should
be looked at for coverage, or any `@codeCoverageIgnore` directives, or
the `test-coverage-html` script in packages/waf, as those may still be
useful for people manually looking at coverage locally.
@jeherve jeherve mentioned this pull request Sep 7, 2023
Merged
3 tasks
tbradsha added a commit that referenced this pull request Oct 30, 2024
@tbradsha
Revert "Code Coverage: remove automation (#28542)"
20082d6 
This reverts commit da5e788.
@tbradsha tbradsha mentioned this pull request Oct 30, 2024
Merged
3 tasks
tbradsha added a commit that referenced this pull request Oct 31, 2024
@tbradsha @anomiex
Monorepo: Restore and add test coverage config (#39961)
7fadf4a 
* Enable and normalize test coverage commands

* Revert "Code Coverage: remove automation (#28542)"

This reverts commit da5e788.

* Revert "Remove remnants of automated code coverage support (#28982)"

This reverts commit 8cc3246.

* Fix starter plugin test broken by #31417

* Plugin tests are now run in the monorepo rather than wp-content/plugins.

* Removed undocumented WP_DEVELOP_DIR variable, documented WORDPRESS_DEVELOP_DIR and WORDPRESS_DIR

* Fixed JS tests in some packages where .scripts.test-js had never been added to composer.json.

---------

Co-authored-by: Brad Jorsch <brad.jorsch@automattic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@dereksmart dereksmart Awaiting requested review from dereksmart

Assignees

@kraftbj kraftbj

Labels
Actions GitHub actions used to automate some of the work around releases and repository management [Tools] Development CLI The tools/cli to assist during JP development.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kraftbj @jeherve