Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use flex-start instead of start for better browser compatibility #28530

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Use flex-start instead of start for better browser compatibility #28530

merged 2 commits into from
Jan 25, 2023

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Jan 23, 2023

Proposed changes:

In various of our builds, postcss's autoprefixer is issuing the following warning

autoprefixer: start value has mixed support, consider using flex-start instead

According to caniuse, of our supported browsers Safari does not recognize start. According to the spec, flex-start is supposed to behave the same as start even if one of these winds up being used outside of a flex context.

And the same for flex-end versus end.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • There should be no change to the display of the relevant content.

@anomiex
Use flex-start instead of start for better browser compatibility
f74973d 
In various of our builds, postcss's autoprefixer is issuing the
following warning
```
autoprefixer: start value has mixed support, consider using flex-start instead
```

According to [caniuse][1], of our supported browsers Safari does not
recognize `start`. According to [the spec][2], `flex-start` is supposed
to behave the same as `start` even if one of these winds up being used
outside of a flex context.

And the same for `flex-end` versus `end`.

[1]: https://caniuse.com/mdn-css_properties_align-items_flex_context_start_end
[2]: https://w3c.github.io/csswg-drafts/css-align/#positional-values
@anomiex anomiex added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Pri] Normal labels Jan 23, 2023
@anomiex anomiex self-assigned this Jan 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2023 •
edited
Loading

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run bin/jetpack-downloader test jetpack fix/css-warning-about-start to get started. More details: p9dueE-5Nn-p2

@github-actions github-actions bot added [Block] Business Hours [JS Package] Connection [JS Package] Components [JS Package] Licensing [Package] My Jetpack [Package] VideoPress [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Social Issues about the Jetpack Social plugin RNA labels Jan 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2023 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: February 7, 2023.
  • Scheduled code freeze: January 31, 2023.

Social plugin:

  • Next scheduled release: February 7, 2023.
  • Scheduled code freeze: January 31, 2023.

Protect plugin:

  • Next scheduled release: February 7, 2023.
  • Scheduled code freeze: January 30, 2023.

@anomiex anomiex enabled auto-merge (squash) January 23, 2023 16:25
@anomiex anomiex merged commit ce8b03e into trunk Jan 25, 2023
@anomiex anomiex deleted the fix/css-warning-about-start branch January 25, 2023 21:42
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Jan 25, 2023
n3f pushed a commit that referenced this pull request Jan 27, 2023
@anomiex @n3f
[not verified] Use flex-start instead of start for better browser…
644dfd1 
… compatibility (#28530)

In various of our builds, postcss's autoprefixer is issuing the
following warning
```
autoprefixer: start value has mixed support, consider using flex-start instead
```

According to [caniuse][1], of our supported browsers Safari does not
recognize `start`. According to [the spec][2], `flex-start` is supposed
to behave the same as `start` even if one of these winds up being used
outside of a flex context.

And the same for `flex-end` versus `end`.

[1]: https://caniuse.com/mdn-css_properties_align-items_flex_context_start_end
[2]: https://w3c.github.io/csswg-drafts/css-align/#positional-values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeymitr sergeymitr sergeymitr approved these changes

Assignees

@anomiex anomiex

Labels
[Block] Business Hours [JS Package] Components [JS Package] Connection [JS Package] Licensing [Package] My Jetpack [Package] VideoPress [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Social Issues about the Jetpack Social plugin [Pri] Normal RNA [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anomiex @sergeymitr