Add/open ai useselect #28483

millerf · 2023-01-20T10:06:38Z

Proposed changes:

It works with unsaved posts,
It handles multiple AI paragraph blocks at the same time
Updates nb of charcaters left dynamically
Takes into accounts categories and tags
Code is not spaghetti-based

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Sandbox a WPCOM site and push this to your favorite sandbox with

$> ~/public_html/bin/jetpack-downloader test jetpack add/open-ai-useselect

create a new post
add a title only
create AI paragraph
it should tell you it misses characters. Enter some and voilà.
add another AI parapgrah blocks behind it, it should say it needs to wait for the previous block to fini

Open the console and play with it, you can add/remove categories and tags, and it should send the right prompts.

github-actions · 2023-01-20T10:07:45Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
⚠️ All commits were linted before commit.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

Next scheduled release: February 7, 2023.
Scheduled code freeze: January 31, 2023.

github-actions · 2023-01-20T10:07:46Z

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run bin/jetpack-downloader test jetpack add/open-ai-useselect to get started. More details: p9dueE-5Nn-p2

projects/plugins/jetpack/extensions/blocks/ai-paragraph/edit.js

artpi · 2023-01-20T12:24:01Z

This may be kind of relevant #28488

n3f

Looks good to me. I added some comments that aren't necessarily blockers, but I would like others to look before I approved!

projects/plugins/jetpack/extensions/blocks/ai-paragraph/edit.js

n3f · 2023-01-20T23:18:44Z

projects/plugins/jetpack/extensions/blocks/ai-paragraph/edit.js

+	const waitingState = completionFinished || loadingCompletion || loadingCategories;
+	const nbCharactersNeeded = numberOfCharactersNeeded - content.length;
+	if ( ! waitingState ) {
+		if ( containsAiUntriggeredParapgraph( contentBefore ) ) {
+			if ( ! errorMessage ) {
+				setErrorMessage(
+					/** translators: This will be an error message when multiple Open AI paragraph blocks are triggered on the same page. */
+					__( 'Waiting for the previous AI paragraph block to finish', 'jetpack' )
+				);
+			}
+		} else if (
+			content.length < numberOfCharactersNeeded &&
+			needsMoreCharacters !== nbCharactersNeeded
+		) {
+			setErrorMessage(
+				sprintf(
+					/** translators: First placeholder is a number of more characters we need */
+					__(
+						'Please write a longer title or a few more words in the opening preceding the AI block. Our AI model needs %1$d more characters.',
+						'jetpack'
+					),
+					nbCharactersNeeded
+				)
 			);
+			setNeedsMoreCharacters( nbCharactersNeeded );
+		} else if ( needsMoreCharacters !== 0 && content.length >= numberOfCharactersNeeded ) {
+			setErrorMessage(
+				/** translators: This is to retry to complete the text */
+				__( 'Ready to retry', 'jetpack' )
+			);
+			setShowRetry( true );
+			setNeedsMoreCharacters( 0 );
+		} else if ( needsMoreCharacters === 0 && ! showRetry ) {
+			getSuggestionFromOpenAI();
 		}
-	}, [ setAttributes, attributes ] ); // eslint-disable-line react-hooks/exhaustive-deps
+	}


Should this all just go in a useEffect?

useEffect( () => { if ( completionFinished || loadingCompletion || loadingCategories ) { return; } // ... }, [ completionFinished, loadingCompletion, loadingCategories ] );

See my other comment above about the logic of that if not being correct...

projects/plugins/jetpack/extensions/blocks/ai-paragraph/edit.js

millerf · 2023-01-25T09:03:12Z

if it's an OpenAI caching issue and not the prompt changing either...

Should we have some sort of a timer/message saying that the response won't change for a minute...

Definitely. That will be in another PR, though.

artpi · 2023-01-25T12:13:26Z

Definitely. That will be in another PR, though.

Yes, that should be another PR

artpi

This tests well, I think I have enough of this PR :D

artpi

Merged master, resolved conflicts and accepting again

millerf · 2023-01-25T15:20:30Z

This tests well, I think I have enough of this PR :D

So do I...

millerf added 2 commits January 20, 2023 11:03

[not verified] first try

097ab96

changelog

5d6d3ad

millerf marked this pull request as draft January 20, 2023 10:06

github-actions bot added [Block] AI Paragraph [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Jan 20, 2023

github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 20, 2023

artpi reviewed Jan 20, 2023

View reviewed changes

projects/plugins/jetpack/extensions/blocks/ai-paragraph/edit.js Outdated Show resolved Hide resolved

artpi reviewed Jan 20, 2023

View reviewed changes

projects/plugins/jetpack/extensions/blocks/ai-paragraph/edit.js Outdated Show resolved Hide resolved

artpi reviewed Jan 20, 2023

View reviewed changes

projects/plugins/jetpack/extensions/blocks/ai-paragraph/edit.js Outdated Show resolved Hide resolved

millerf added 2 commits January 20, 2023 13:19

Some cleanup, add retry button

0b8fc57

Some fix

a0a095f

github-actions bot added the [Status] In Progress label Jan 20, 2023

millerf mentioned this pull request Jan 20, 2023

[Jetpack AI] Fix regression when loading the saved block editor #28488

Merged

millerf added 5 commits January 20, 2023 17:17

Some re-work

ca3fc4b

More fixes

ebe2ab9

Refactor logic

d16bb2a

Refactor logic

69828a5

Add animated text

e3977f2

millerf force-pushed the add/open-ai-useselect branch from f5b43ca to e3977f2 Compare January 20, 2023 18:59

Fix issue when not enough characters are needed

cdcafc0

millerf self-assigned this Jan 20, 2023

millerf requested review from romarioraffington, n3f and artpi January 20, 2023 19:12

millerf marked this pull request as ready for review January 20, 2023 19:16

n3f reviewed Jan 20, 2023

View reviewed changes

projects/plugins/jetpack/extensions/blocks/ai-paragraph/edit.js Outdated Show resolved Hide resolved

Pleasing the crowd

19b7ec9

millerf dismissed stale reviews from romarioraffington, n3f, and artpi via 19b7ec9 January 25, 2023 09:01

relaunch tests

a687cd8

millerf added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 25, 2023

millerf requested review from artpi, n3f, romarioraffington and ntsekouras January 25, 2023 09:54

millerf removed the [Status] In Progress label Jan 25, 2023

artpi previously approved these changes Jan 25, 2023

View reviewed changes

Merge branch 'trunk' into add/open-ai-useselect

620824a

artpi dismissed their stale review via 620824a January 25, 2023 14:22

artpi approved these changes Jan 25, 2023

View reviewed changes

artpi requested a review from jeherve January 25, 2023 14:48

millerf mentioned this pull request Jan 25, 2023

[AI] Better openAi prompt #28565

Merged

jeherve approved these changes Jan 25, 2023

View reviewed changes

millerf merged commit 5772ba0 into trunk Jan 25, 2023

jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jan 25, 2023

millerf deleted the add/open-ai-useselect branch January 25, 2023 15:32

github-actions bot added this to the jetpack/11.8 milestone Jan 25, 2023

github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jan 25, 2023

artpi mentioned this pull request Jan 26, 2023

[Jetpack AI] Fix the block for post types without categories (like pages) #28602

Closed

millerf mentioned this pull request Jan 26, 2023

Fix when categories or tags are empty #28604

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add/open ai useselect #28483

Add/open ai useselect #28483

millerf commented Jan 20, 2023 •

edited

Loading

github-actions bot commented Jan 20, 2023 •

edited

Loading

github-actions bot commented Jan 20, 2023 •

edited

Loading

artpi commented Jan 20, 2023

n3f left a comment

n3f Jan 20, 2023 •

edited

Loading

n3f Jan 20, 2023 •

edited

Loading

millerf commented Jan 25, 2023

artpi commented Jan 25, 2023

artpi left a comment

artpi left a comment

millerf commented Jan 25, 2023

Add/open ai useselect #28483

Add/open ai useselect #28483

Conversation

millerf commented Jan 20, 2023 • edited Loading

Proposed changes:

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Jan 20, 2023 • edited Loading

github-actions bot commented Jan 20, 2023 • edited Loading

artpi commented Jan 20, 2023

n3f left a comment

Choose a reason for hiding this comment

n3f Jan 20, 2023 • edited Loading

Choose a reason for hiding this comment

n3f Jan 20, 2023 • edited Loading

Choose a reason for hiding this comment

millerf commented Jan 25, 2023

artpi commented Jan 25, 2023

artpi left a comment

Choose a reason for hiding this comment

artpi left a comment

Choose a reason for hiding this comment

millerf commented Jan 25, 2023

millerf commented Jan 20, 2023 •

edited

Loading

github-actions bot commented Jan 20, 2023 •

edited

Loading

github-actions bot commented Jan 20, 2023 •

edited

Loading

n3f Jan 20, 2023 •

edited

Loading

n3f Jan 20, 2023 •

edited

Loading