Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E tests: remove check for post page #28299

Merged
merged 3 commits into from
Jan 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tools/e2e-commons/bin/e2e-env.sh
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ configure_wp_env() {
fi
$BASE_CMD wp option set permalink_structure ""
$BASE_CMD wp jetpack module deactivate sso
$BASE_CMD wp theme activate twentytwentyone

echo
$BASE_CMD wp plugin status
Expand Down
2 changes: 1 addition & 1 deletion tools/e2e-commons/pages/page-actions.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export default class PageActions {
await this.waitForDomContentLoaded();
}

if ( checkSelectors ) {
if ( checkSelectors && this.selectors ) {
for ( const selector of this.selectors ) {
await this.waitForElementToBeVisible( selector );
}
Expand Down
2 changes: 1 addition & 1 deletion tools/e2e-commons/pages/postFrontend.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { resolveSiteUrl } from '../helpers/utils-helper.cjs';
export default class PostFrontendPage extends WpPage {
constructor( page ) {
const url = resolveSiteUrl();
super( page, { expectedSelectors: [ '.post' ], url } );
super( page, { url } );
}

/**
Expand Down
2 changes: 1 addition & 1 deletion tools/e2e-commons/pages/wp-admin/blocks/word-ads.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export default class WordAdsBlock extends PageActions {
*/
static async isRendered( page ) {
// We check for either the ads placeholder div, or the iframes if the ads are loaded.
const containerSelector = ".entry-content iframe[src*='wordads'],article .wpa";
const containerSelector = ".entry-content iframe[src*='wordads'],main .wpa .wpa-about";
await page.waitForSelector( containerSelector );
}
}