Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS Components: Convert JetpackFooter component to TypeScript #25295

Merged
merged 10 commits into from
Aug 1, 2022

Conversation

manzoorwanijk
Copy link
Member

@manzoorwanijk manzoorwanijk commented Jul 27, 2022

Changes proposed in this Pull Request:

  • This PR converts JetpackFooter component to TypeScript.
  • It also converts the JetpackFooter stories and unit tests to TS
  • Adds more test cases for JetpackFooter unit tests

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Checkout the PR
  • Run cd projects/js-packages/storybook && pnpm run storybook:dev
  • Confirm that all the stories of JetpackFooter component work as expected
  • Check the consumers of JetpackFooter and related components and confirm that they work as expected
  • Check for any regression

Screenshot 2022-08-01 at 1 37 26 PM


  • To see the specific tasks where the Asana app for GitHub is being used, see below:
    • 0-as-1202276314264001

@manzoorwanijk manzoorwanijk added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Task RNA [JS Package] Components labels Jul 27, 2022
@manzoorwanijk manzoorwanijk requested a review from a team July 27, 2022 12:14
@manzoorwanijk manzoorwanijk self-assigned this Jul 27, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello manzoorwanijk! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D84905-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@dhasilva
Copy link
Contributor

It seems the controls are not there anymore:
https://automattic.github.io/jetpack-storybook/?path=/story/js-packages-components-jetpack-footer--default

Before After
Screenshot_2022-07-29_17-33-36-bef Screenshot_2022-07-29_17-33-11

@dhasilva dhasilva added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jul 29, 2022
@manzoorwanijk manzoorwanijk added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Aug 1, 2022
@manzoorwanijk
Copy link
Member Author

It seems the controls are not there anymore: https://automattic.github.io/jetpack-storybook/?path=/story/js-packages-components-jetpack-footer--default

@dhasilva Thank you for catching that. It looks like an issue with Storybook that default props don't seem to work with ES6 default values - storybookjs/storybook#9626

I have added explicit default values.

Copy link
Contributor

@dhasilva dhasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀
Screenshot_2022-08-01_10-30-48

@dhasilva dhasilva added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Aug 1, 2022
@manzoorwanijk manzoorwanijk enabled auto-merge (squash) August 1, 2022 13:35
@manzoorwanijk manzoorwanijk merged commit bf00452 into trunk Aug 1, 2022
@manzoorwanijk manzoorwanijk deleted the update/rna-jetpack-footer-to-ts branch August 1, 2022 13:37
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2022

Great news! One last step: head over to your WordPress.com diff, D84905-code, and deploy it.
Once you've done so, come back to this PR and add a comment with your SVN changeset ID (e.g. r12345-wpcom).

Thank you!

@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Aug 1, 2022
@manzoorwanijk
Copy link
Member Author

r249899-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants