-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS Components: Convert JetpackFooter component to TypeScript #25295
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
Caution: This PR has changes that must be merged to WordPress.com |
It seems the controls are not there anymore:
|
@dhasilva Thank you for catching that. It looks like an issue with Storybook that default props don't seem to work with ES6 default values - storybookjs/storybook#9626 I have added explicit default values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great news! One last step: head over to your WordPress.com diff, D84905-code, and deploy it. Thank you! |
r249899-wpcom |
Changes proposed in this Pull Request:
JetpackFooter
component to TypeScript.JetpackFooter
stories and unit tests to TSJetpackFooter
unit testsOther information:
Does this pull request change what data or activity we track or use?
No
Testing instructions:
cd projects/js-packages/storybook && pnpm run storybook:dev
JetpackFooter
component work as expectedJetpackFooter
and related components and confirm that they work as expected