Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

live-branches: Allow for not installing Jetpack #24843

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Jun 27, 2022

Changes proposed in this Pull Request:

Jurassic Ninja installs the release version of the Jetpack plugin by
default, unless a nojetpack option is supplied. Let's add a UI for
that to simplify testing of the standalone plugins without Jetpack
itself installed.

To keep the UI simple, we add "Jetpack" in the existing "Plugins" list,
pre-checked to preserve the current behavior as the default. In the JS
we invert the sense of this checkbox so nojetpack is added to the URL
when the checkbox is unchecked.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?

Jetpack product discussion

None. But see pdV5qK-2I-p2#comment-81

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Jurassic Ninja installs the release version of the Jetpack plugin by
default, unless a `nojetpack` option is supplied. Let's add a UI for
that to simplify testing of the standalone plugins without Jetpack
itself installed.

To keep the UI simple, we add "Jetpack" in the existing "Plugins" list,
pre-checked to preserve the current behavior as the default. In the JS
we invert the sense of this checkbox so `nojetpack` is added to the URL
when the checkbox is unchecked.
@anomiex anomiex added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Pri] Normal labels Jun 27, 2022
@anomiex anomiex self-assigned this Jun 27, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@anomiex anomiex enabled auto-merge (squash) June 27, 2022 14:39
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2 "Jetpack" entries and the disappearing link when you unselect the 2 checkboxes may be a bit confusing, but this works.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jun 28, 2022
@anomiex anomiex merged commit 950ce39 into trunk Jun 28, 2022
@anomiex anomiex deleted the add/live-branches-allow-no-jetpack branch June 28, 2022 06:26
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants